-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move server info to the admin page #18
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schiessle
force-pushed
the
move-to-admin-page
branch
from
August 10, 2016 14:09
e8cbaf9
to
49804dc
Compare
<namespace>ServerInfo</namespace> | ||
<category>other</category> | ||
<dependencies> | ||
<owncloud min-version="9.1" max-version="9.2" /> | ||
</dependencies> | ||
<default_enable/> | ||
<settings> | ||
<admin>\OCA\ServerInfo\Settings\Admin</admin> | ||
 <admin-section>\OCA\ServerInfo\Settings\Section</admin-section> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange indentation?
schiessle
force-pushed
the
move-to-admin-page
branch
2 times, most recently
from
August 10, 2016 14:55
ca760bc
to
741ff29
Compare
Merged
schiessle
force-pushed
the
move-to-admin-page
branch
from
August 11, 2016 13:19
741ff29
to
1d9c803
Compare
This was referenced Aug 11, 2016
schiessle
force-pushed
the
move-to-admin-page
branch
from
August 16, 2016 19:24
4e3280c
to
1673e3d
Compare
schiessle
force-pushed
the
move-to-admin-page
branch
from
August 16, 2016 19:43
1673e3d
to
a9f2ea2
Compare
@blizzz @nickvergessen do you want to have a short look at it? Thanks! |
changes look good and it also works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display server infos in the admin settings, instead of a dedicated app view.
tested with: nextcloud/server@ce6ad5d
stable10 backport needed as soon as nextcloud/server#796 was backported